[concurrency] fixes to enable building swift with concurrency on by default #34609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues when building Swift with concurrency enabled by default. See rdar://71045297 If some of our overlays need to use the concurrency API, they can manually import _Concurrency.
DougGregor
approved these changes
Nov 6, 2020
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue when building the compiler with concurrency enabled by default comes up when the build system begins to build the standard library, etc. The error emitted during the build says that the
_ConcurrencySwift module was not found. After some discussion with Doug, the best way to fix this issue is to add a flag to the frontend that disables the implicit inclusion of_Concurrencyby the compiler, and add that flag when building those libraries during the build of Swift.Resolves rdar://71045297
TODO
_Concurrencymodule