[Concurrency] Implement a builtin createAsyncTask() to create a new task #34627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ask. `Builtin.createAsyncTask` takes flags, an optional parent task, and an async/throwing function to execute, and passes it along to the `swift_task_create_f` entry point to create a new (potentially child) task, returning the new task and its initial context.
The `createAsyncTask` entry point expects the parent task to be "guaranteed" and the function to be "owned". However, that's not easy to model in the operand ownership map, so we consider all operands to be "guaranteed" and balance out the reference count when lowering the builtin. This is an egregious hack that will create a little extra reference count traffic.
|
@swift-ci test |
|
@swift-ci please smoke test |
ktoso
approved these changes
Nov 10, 2020
|
I think I'll land this and clean things up later. There are a couple of moving pieces here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builtin.createAsyncTasktakes flags, an optional parent task, and anasync/throwing function to execute, and passes it along to the
swift_task_create_fentry point to create a new (potentially child)task, returning the new task and its initial context.