[concurrency] allow code to shadow definitions in implicit _Concurrency module #34642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
approved these changes
Nov 9, 2020
kavon
force-pushed
the
shadowing-concurrency-lib
branch
from
d517ccb to
5468b2e
Compare
|
@swift-ci please smoke test and merge |
rxwei
added a commit
to rxwei/swift
that referenced
this pull request
May 2, 2022
… module. Treat _StringProcessing decls as if it were declared in the Swift module, just like how _Concurrency is treated (swiftlang#34642).
rxwei
added a commit
to rxwei/swift
that referenced
this pull request
May 4, 2022
… module. Treat _StringProcessing decls as if it were declared in the Swift module, just like how _Concurrency is treated (swiftlang#34642).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce the impact of source compatibility breakages with the proposed concurrency extensions, this PR implements the same type of shadowing rule that applies to the Swift standard library: unqualified references to declarations imported from both the
_Concurrencymodule and some other moduleAwill always prefer moduleA's declaration.Resolves rdar://71045297
TODO: