Skip to content

[concurrency] update test missed in #34640, resolving rdar://71212904 #34650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

kavon
Copy link
Member

@kavon kavon commented Nov 9, 2020

Resolves rdar://71212904.

@kavon
Copy link
Member Author

kavon commented Nov 9, 2020

@swift-ci please smoke test and merge

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kavon
Copy link
Member Author

kavon commented Nov 10, 2020

The Linux smoke test failed with:

FAIL: Swift-Unit :: runtime/./SwiftRuntimeTests/ConcurrentReadableArrayTest.MultiThreaded2 (608 of 13768)
******************** TEST 'Swift-Unit :: runtime/./SwiftRuntimeTests/ConcurrentReadableArrayTest.MultiThreaded2' FAILED ********************
Note: Google Test filter = ConcurrentReadableArrayTest.MultiThreaded2
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ConcurrentReadableArrayTest
[ RUN      ] ConcurrentReadableArrayTest.MultiThreaded2
/home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-main/swift/unittests/runtime/Concurrent.cpp:134: Failure
Expected: (element.threadNumber) < (writerCount), actual: 528 vs 16
[  FAILED  ] ConcurrentReadableArrayTest.MultiThreaded2 (2084 ms)
[----------] 1 test from ConcurrentReadableArrayTest (2084 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2084 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ConcurrentReadableArrayTest.MultiThreaded2

 1 FAILED TEST

This is either a spurious test failure or a pre-existing condition of main. Logged in rdar://71218851 and am trying the merge again.

@kavon
Copy link
Member Author

kavon commented Nov 10, 2020

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit cdfff19 into swiftlang:main Nov 10, 2020
@kavon kavon deleted the regression-71212904 branch November 10, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants