[ownership] Extract out SILOwnershipKind from ValueOwnershipKind into its own type and rename Invalid -> Any. #34669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
@atrick I also put in some ascii art that shows the lattice: https://github.com/apple/swift/pull/34669/files#diff-7f261169f338bde9847b6fc72d36c2657ab1e46e8dfd4db1bd834e8657edba13R91 |
atrick
reviewed
Nov 10, 2020
… its own type and rename Invalid -> Any. This makes it easier to understand conceptually why a ValueOwnershipKind with Any ownership is invalid and also allowed me to explicitly document the lattice that relates ownership constraints/value ownership kinds.
gottesmm
force-pushed
the
pr-e67e6b91001b244349fb8858b70cfa52b2738c8d
branch
from
147d7da to
c026e95
Compare
|
@swift-ci smoke test |
atrick
approved these changes
Nov 10, 2020
|
That was the only change I made. Everything else is the same. |
|
@swift-ci clean smoke test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to understand conceptually why a ValueOwnershipKind with
Any ownership is invalid and also allowed me to explicitly document the lattice
that relates ownership constraints/value ownership kinds.