Skip to content

Revert "CMake: generate SupportedFeatures.json while building and install it into toolchain" #34685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Nov 11, 2020

Reverts #34655

Addresses rdar://71282911

@edymtt
Copy link
Contributor Author

edymtt commented Nov 11, 2020

@swift-ci please build toolchain

@edymtt
Copy link
Contributor Author

edymtt commented Nov 11, 2020

@swift-ci please smoke test

@edymtt
Copy link
Contributor Author

edymtt commented Nov 11, 2020

Root cause is addressed in #34686, keeping this around in case I misunderstood the fix

@shahmishal shahmishal merged commit 17d6843 into main Nov 11, 2020
@shahmishal shahmishal deleted the revert-34655-install-feature-json branch November 11, 2020 17:02
@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 7771508

Install command
tar zxf swift-PR-34685-493-ubuntu16.04.tar.gz
More info

@nkcsgexi
Copy link
Contributor

Thank you for reverting this!

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - 7771508

Install command
tar -zxf swift-PR-34685-766-osx.tar.gz --directory ~/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants