Prevent superfluous diagnostic-database execution #34698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dependencies and output to the diagnostic-database target so that it's not re-run every time swift-frontend is compiled.
|
@swift-ci please test |
|
@swift-ci please build toolchain |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
macOS Toolchain Install command |
|
Toolchain looks okay to me. Linux: OSX: |
|
Great! |
compnerd
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a while back that diagnostic-database was running on every compilation. Doesn't really matter since it's quite fast, but I was looking through some CMake stuff today so thought I'd fix it up.
This change just adds dependencies to the two binaries and an output witness file so that it's only re-run when actually required (ie. the binaries change/output isn't there). It should also add the files copied over when they're actually added, that directory is empty at the moment. I considered adding a glob + CONFIGURE_DEPENDS for this but figured we could do that later if wanted.