[sil] When parsing if we find an error when parsing a SILBasicBlock emit a misc error showing the block that failed. #34699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mit a misc error showing the block that failed. Otherwise, if for some reason we did not emit a diagnostic, we will just emit an empty SILModule without any diagnostic which can be really confusing. This ensures at least something is emitted. I wanted to do this only if we actually emitted an error, but given that once we emit a first error, we can't tell if we emitted more errors (we only know that we emitted errors), we always emit this diagnostic on error. That is better than just being confused about an empty sil module being output.
|
@swift-ci smoke test |
meg-gupta
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, if for some reason we did not emit a diagnostic, we will just emit an
empty SILModule without any diagnostic which can be really confusing. This
ensures at least something is emitted.
I wanted to do this only if we actually emitted an error, but given that once we
emit a first error, we can't tell if we emitted more errors (we only know that
we emitted errors), we always emit this diagnostic on error. That is better than
just being confused about an empty sil module being output.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.