Unconditionally Record Type Body Fingerprints #34700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to disable these for extensions, which meant changes to extensions would pessimistically cause every decl in the file to be considered dirty.
|
@swift-ci smoke test |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to disable these for extensions, which meant changes to extensions would pessimistically cause every decl in the file to be considered dirty.
The test here was incorrect - there was no use of
A.x, and computed properties do not contribute to the implicit initializer generated for the structA, so there was no reason to rebuild the other file. I've corrected the test to introduce an overload of the default initializer instead, which will actually detect if we fail to track the member use here.