Tbkka/dynamic casting tests #34732
Merged
Tbkka/dynamic casting tests #34732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a generic `is` test for a struct conforming to a protocol. Resolves rdar://70999129 Resolves SR-13812
Resolves SR-8964 Resolves rdar://45217461
Resolves rdar://48769924
Resolves rdar://35321438
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please clean test Linux |
|
Build failed |
|
Build failed |
|
@swift-ci Please test |
ainu-bot
added a commit
to google/swift
that referenced
this pull request
Nov 17, 2020
* 'main' of github.com:apple/swift: More dynamic casting tests (swiftlang#34732)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for a number of Swift SR reports and Radars that were fixed by the recent dynamic casting overhaul, to help ensure that these issues were really fixed and will remain fixed in the future.
Note that the last test here for SR-12025 does not currently pass. I've added a test anyway just to help document the issue and help us recognize when it does get fixed.