Skip to content

Fix SILVerifier assert for witness_method with dynamic self type #34738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Fix SILVerifier assert for witness_method with dynamic self type #34738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/SIL/Verifier/SILVerifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3020,15 +3020,15 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
"requirement Self parameter must conform to called protocol");

auto lookupType = AMI->getLookupType();
if (getOpenedArchetypeOf(lookupType)) {
if (getOpenedArchetypeOf(lookupType) || isa<DynamicSelfType>(lookupType)) {
require(AMI->getTypeDependentOperands().size() == 1,
"Must have a type dependent operand for the opened archetype");
verifyOpenedArchetype(AMI, lookupType);
} else {
require(AMI->getTypeDependentOperands().empty(),
"Should not have an operand for the opened existential");
}
if (!isa<ArchetypeType>(lookupType)) {
if (!isa<ArchetypeType>(lookupType) && !isa<DynamicSelfType>(lookupType)) {
require(AMI->getConformance().isConcrete(),
"concrete type lookup requires concrete conformance");
auto conformance = AMI->getConformance().getConcrete();
Expand Down