[Async CC] Resolve metadata from class instances. #34740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
nate-chandler
changed the title
|
Build failed |
|
Build failed |
|
@swift-ci please clean test linux |
|
@swift-ci please clean test macos |
|
Build failed |
|
@swift-ci please clean test linux |
|
Build failed |
|
@swift-ci please clean test macos |
nate-chandler
force-pushed
the
concurrency/irgen/rdar71260862
branch
from
907f17e to
2dde2e7
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Metadata for an instance of a type is resolved by extracting it from an instance of the class. When doing method lookup for an instance method of a resilient class, the lowered self value was being obtained from the list of arguments directly by indexing. That does not apply to async functions where self is embedded within the async context. Here, the self parameter is extracted from the async context so that the metadata can in turn be extracted from it. rdar://problem/71260862
nate-chandler
force-pushed
the
concurrency/irgen/rdar71260862
branch
from
2dde2e7 to
e276472
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata for an instance of a type is resolved by extracting it from an instance of the class. When doing method lookup for an instance method of a resilient class, the lowered self value was being obtained from the list of arguments directly by indexing. That does not apply to async functions where self is embedded within the async context. Here, the self parameter is extracted from the async context so that the metadata can in turn be extracted from it.
rdar://problem/71260862