Specify the unchecked_ownership_conversion instruction #34742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All SIL instructions need their semantics specified in SIL.rst and their constraints specified in SILVerifier.
That prevents the SILVerifier from printing the context, making it hard to quickly produce test cases from logs. Instead, just return the failure status to the SILVerifier so it can do its diagnostic thing. An assert or llvm_unreachable would also be fine in addition to the normal SILVerifier diagnostics, but I don't think that's needed here.
|
@swift-ci smoke test |
I can't reason about whether this is correct to do, because SIL both uses the side-effects semantics to model arbitrary implicit dependencies and simultaneously considers them to be memory writes. What's more, the SIL instruction definitions almost *never* specify the actual constraints that we're attempting to approximate with the model. Be that as it may, we can't verify SIL if we "conservatively" consider instructions that don't write to memory to be writes. So I'll attempt to fix the undocumented model and find out what breaks. Fixes rdar://70737095 Unknown instruction: unchecked_ownership_conversion
atrick
force-pushed
the
fix-unchecked-ownership
branch
from
6a9e6da to
f529072
Compare
|
@swift-ci test |
|
@swift-ci test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And a few minor commits related to verification of this instruction.