[Async CC] Never map to native explosions. #34743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
nate-chandler
force-pushed
the
concurrency/irgen/rdar71260972
branch
from
4e09a7e to
f3c7af5
Compare
|
@swift-ci please test |
nate-chandler
force-pushed
the
concurrency/irgen/rdar71260972
branch
from
f3c7af5 to
e988047
Compare
|
@swift-ci please test |
|
Build failed |
Previously, when lowering the entry point of an async function, the parameters were lowered to explosions that matched those of sync functions, namely native explosions. That is incorrect for async functions where the structured values are within the async context. Here, that error is fixed, by adding a new customization point to NativeCCEntryPointArgumentEmission which behaves as before for sync functions but which simply extracts an argument from the async context for async functions. rdar://problem/71260972
nate-chandler
force-pushed
the
concurrency/irgen/rdar71260972
branch
from
e988047 to
11723cc
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test |
|
Merging broke the build: the test's behavior changed after the tests passed. A PR that fixes the test is here: #34748 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when lowering the entry point of an async function, the parameters were lowered to explosions that matched those of sync functions, namely native explosions. That is incorrect for async functions where the structured values are within the async context. Here, that error is fixed, by adding a new customization point to NativeCCEntryPointArgumentEmission which behaves as before for sync functions but which simply extracts an argument from the async context for async functions.
rdar://problem/71260972