[ConstraintSystem] Detect and diagnose extraneous return(s) in result build body #34810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
hborla
reviewed
Nov 20, 2020
…r and warning versions
…result build body
…sult builder body
…tatements in a result builder body
…return' statement(s)
|
@swift-ci please smoke test |
hborla
approved these changes
Nov 20, 2020
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows platform |
1 similar comment
|
@swift-ci please smoke test Windows platform |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
2 similar comments
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is (hopefully) the last source of "failed to produce a diagnostic" related to result builder
where having a
returnwould just assume that body is a regular closure just to fail a bit later.Instead of doing that (in diagnostic mode) let's mark body with explicit returns as invalid and
carry on solving to diagnose it if it was possible to reach a solution, this would also mean
that situations where nested result builders have
returnstatements are going to be correctlydiagnosed.
Resolves: rdar://problem/66709164