Skip to content

Two small SIL verifier improvements #34827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Conversation

eeckstein
Copy link
Contributor

  • Don't enforce that there must be an unreachable after a no-return apply.

This condition does not hold after each pass. It's only the case after running some cleanup-passes.
This verifier condition makes it impossible to bisect the optimization passes.

  • Don't dump the whole module in case of a verifier failure, because modules can be very large.

Only dump the module if the new option -verify-dump-module-on-failure is set.

…no-return apply.

This condition does not hold after each pass. It's only the case after running some cleanup-passes.
This verifier condition makes it impossible to bisect the optimization passes.
... because modules can be _very_ large.
Only dump the module if the new option -verify-dump-module-on-failure is set.
@eeckstein
Copy link
Contributor Author

@swift-ci smoke test and merge

@eeckstein
Copy link
Contributor Author

@swift-ci smoke test macOS

@eeckstein eeckstein merged commit eef89eb into swiftlang:main Nov 19, 2020
@eeckstein eeckstein deleted the fix-verifier branch November 19, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant