[Runtime] Validate scribble data when metadata allocation scribbling is enabled. #34828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This catches the overflow fixed by #34822. |
nate-chandler
approved these changes
Nov 19, 2020
|
@swift-ci please test |
|
Build failed |
mikeash
force-pushed
the
metadata-allocator-scribble-check
branch
from
4f8a64b to
e2d1095
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test os x platform |
|
Build failed |
mikeash
force-pushed
the
metadata-allocator-scribble-check
branch
from
e2d1095 to
d94cbe9
Compare
|
@swift-ci please test os x platform |
|
Build failed |
|
@swift-ci please test os x platform |
mikeash
force-pushed
the
metadata-allocator-scribble-check
branch
from
d94cbe9 to
e0cd86c
Compare
…is enabled. Instead of scribbling each allocation as it's parceled out, scribble the entire chunk up-front. Then, when handing out an allocation, check to make sure it still has the right scribbled data in it.
mikeash
force-pushed
the
metadata-allocator-scribble-check
branch
from
e0cd86c to
b47607c
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test os x platform |
|
Build failed |
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of scribbling each allocation as it's parceled out, scribble the entire chunk up-front. Then, when handing out an allocation, check to make sure it still has the right scribbled data in it.