[Serialization] Serialize Clang types for non-modular headers. #34838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Build failed |
|
Build failed |
varungandhi-apple
force-pushed
the
vg-serde-serialize-non-modular-clang-type
branch
from
4db46f3 to
e69581c
Compare
|
@swift-ci please smoke test |
varungandhi-apple
force-pushed
the
vg-serde-serialize-non-modular-clang-type
branch
from
e69581c to
9ec87a7
Compare
|
@swift-ci please smoke test |
|
This causes a test failure when |
varungandhi-apple
force-pushed
the
vg-serde-serialize-non-modular-clang-type
branch
from
9ec87a7 to
85d4d12
Compare
|
@swift-ci please smoke test |
rjmccall
approved these changes
Nov 30, 2020
varungandhi-apple
deleted the
vg-serde-serialize-non-modular-clang-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since frameworks have modularized headers, this is only a problem for app targets which use non-modular headers. Such an app target's swiftmodule may be used by a test module. If we have an
@convention(c)function type with a non-trivial C type in such an app target, it is probably safe to serialize it optimistically and hope that the test target imports the same headers.