EscapeAnalysis: fix a quadratic behavior in ConnectionGraph::getNode #34867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a compile time problem. The single linked list of merge targets in connection graph nodes can be very large. Update the final merge target in the map, so that it has to be traversed only once for a given SILValue. rdar://problem/71602804
|
@swift-ci test |
gottesmm
reviewed
Nov 28, 2020
| // If the compiler needs more than 5 minutes, there is probably a real problem. | ||
| // So please don't just increase the timeout in case this fails. | ||
|
|
||
| // RUN: %{python} %S/../../test/Inputs/timeout.py 240 %target-swift-frontend -O -parse-as-library -sil-verify-none -c %t/main.swift -o %t/main.o |
There was a problem hiding this comment.
This should really be a scale test, no?
There was a problem hiding this comment.
Well, this is the end-to-end test.
But it's probably worth adding a scale-test, too. I'll take a look.
atrick
reviewed
Dec 1, 2020
There was a problem hiding this comment.
@eeckstein thanks. Hopefully this works out, but I can't be sure without testing with -escapes-internal-verify. Did you do that?
|
No, I was not aware that we have this option. |
|
@eeckstein I don't think any of the -escapes-internal-verify failures are related to this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a compile time problem. The single linked list of merge targets in connection graph nodes can be very large.
Update the final merge target in the map, so that it has to be traversed only once for a given SILValue.
rdar://problem/71602804