Skip to content

test: handle spaces in paths better on macOS tests #34874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

compnerd
Copy link
Member

Ensure that we quote the path to the SDKROOT which may contain spaces.
Failure to so will break the path into multiple components (split on
spaces) and generate an invalid command.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Ensure that we quote the path to the SDKROOT which may contain spaces.
Failure to so will break the path into multiple components (split on
spaces) and generate an invalid command.
@compnerd
Copy link
Member Author

CC: @edymtt @shahmishal

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd compnerd merged commit 54910bd into swiftlang:main Nov 30, 2020
@compnerd compnerd deleted the sdkroots branch November 30, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant