[concurrency] SILGen: emit @asyncHandler functions. #34876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
force-pushed
the
silgen-async-handler
branch
from
0f159f1 to
c0d5710
Compare
|
@swift-ci smoke test |
DougGregor
approved these changes
Nov 30, 2020
| @@ -2870,7 +2874,7 @@ void ASTMangler::appendEntity(const ValueDecl *decl, StringRef EntityOp, | |||
| appendOperator("Z"); | |||
| } | |||
|
|
|||
| void ASTMangler::appendEntity(const ValueDecl *decl) { | |||
| void ASTMangler::appendEntity(const ValueDecl *decl, bool isAsyncHandlerBody) { | |||
There was a problem hiding this comment.
Should this bool be a FunctionManglingKind instead to make it clearer?
There was a problem hiding this comment.
I thought of that, but at the end decided to pass a "bool", because FunctionManglingKind has 3 cases.
We don't introduce a new mangling here. To distinguish the names of the original asyncHandler function and it's generated "body-function", we just mangle the body-function with an async attribute, i.e. as if it was declared as async. This change is mostly to pass information to the ASTMangler to mangle a not async function as "async".
It just calls Task.runDetatched. It's more efficient to have a non-generic compiler intrinsic than to let the compiler call the generic Task.runDetatched. The _runAsyncHandler doesn't have to be generic because the return value of the run function is defined to be Void.
… a non-generic closure argument. It fixes a crash in SILGen if Builtin.createAsyncTaskFuture is used in a non-generic context. I found this by experiment - we don't use it currently in the stdlib. But it doesn't harm to fix this.
An asyncHandler function is split into two functions:
1. The asyncHandler body function: it contains the body of the function, but is emitted as an async function.
2. The original function: it just contains
_runAsyncHandler(operation: asyncHandlerBodyFunction)
rdar://problem/71247879
eeckstein
force-pushed
the
silgen-async-handler
branch
from
c0d5710 to
8e03bd3
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An asyncHandler function is split into two functions:
_runAsyncHandler(operation: asyncHandlerBodyFunction)
To distinguish the names of the original asyncHandler function and it's generated "body-function", the body-function name is mangled with an async attribute, i.e. as if it was declared as async.
rdar://problem/71247879