Skip to content

[Concurrency] Tweak where concurrency tests run #34891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2020

Conversation

DougGregor
Copy link
Member

They need libdispatch (whether on macOS or anywhere else) but don't yet work with arm64e.

ptrauth is not yet implemented for asynchronous functions.
Fixes rdar://71809918.
@DougGregor
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 12b08ae

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 12b08ae

@DougGregor
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Dec 1, 2020

Build failed
Swift Test Linux Platform
Git Sha - cfe2ebd

@swift-ci
Copy link
Contributor

swift-ci commented Dec 1, 2020

Build failed
Swift Test OS X Platform
Git Sha - cfe2ebd

@DougGregor
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Dec 1, 2020

Build failed
Swift Test OS X Platform
Git Sha - 6eb6dd6

@DougGregor
Copy link
Member Author

@swift-ci please test macOS

@DougGregor DougGregor merged commit 5266b99 into swiftlang:main Dec 2, 2020
@DougGregor DougGregor deleted the concurrency-arm64e-disable branch December 2, 2020 00:21
@rjmccall
Copy link
Contributor

rjmccall commented Dec 2, 2020

Suggestion: use a lit feature for "supports concurrency execution" instead of duplicating this across tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants