[Sema] Warn on @_spi imports of modules built from their public interface #34912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…face This warning should help understand missing SPI diagnostics when the compiler loads a public module when a private one is expected. rdar://71859081
|
@swift-ci Please smoke test |
| // RUN: rm %t/SPIHelper.private.swiftinterface | ||
| // RUN: %target-typecheck-verify-swift -I %t | ||
|
|
||
| @_spi(SPIHelper) import SPIHelper // expected-warning {{importation of 'SPIHelper' has an ineffective '@_spi' attribute; it was built from the public interface at}} |
There was a problem hiding this comment.
This message is a bit confusing -- can it say something along the lines of import of 'SPIHelper' will not include SPI symbols, since it was built from the public interface at ...
And could you add a note with a Fix-It to remove the @_spi attribute?
There was a problem hiding this comment.
Thank you for the suggestion, I updated the diagnostic message.
For now I prefer to avoid having a fix-it here because removing the attribute is not the solution to where I expect to see this error. The likely solution is probably to change the framework search paths or something like that.
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning should help understand missing SPI diagnostics when the
compiler loads a public module when a private one is expected.
rdar://71859081