Render symbol graphs for cross-import overlay modules, if present #34922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@brentdax could you review since this is about cross-import overlays? |
beccadax
approved these changes
Dec 10, 2020
QuietMisdreavus
force-pushed
the
QuietMisdreavus/overlay-symbol-graph
branch
from
36d0528 to
bf9274d
Compare
|
@swift-ci Please smoke test |
|
The |
|
I wonder if this is related to this bug: https://bugs.swift.org/browse/SR-13635 |
|
Going to try again and blame some flaky cmark tests... @swift-ci Please clean smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the symbol graph tool does not emit information about cross-import overlay modules that the given module declares. This PR proposes probing the currently-known module list after rendering the main symbol graph to determine whether there are any underscore-named modules which overlay the given one, and then rendering additional symbol graphs for them as well, as if they were extensions.
This change includes a new field in the symbol graph format,
module.bystanders, which lists the "bystander modules" that must be imported alongside the mainmodule.namemodule to access the overlay's items. The presence ofmodule.bystandersapplies to all the symbols in the file. Because of the new field, i bumped the symbol graph file format version to 0.5.1.Resolves rdar://59688006