Fix the build and implementation of the 16-byte atomics for MSVC #34958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credit for the cmake fix here goes to Saleem Abdulrasool. The substantive fix is embarrassing; I didn't pay close attention to the intrinsic's argument order and just assumed that the first argument for the replacement value was the low half (the part you'd find at index 0 if it were an array), but in fact it's the high half (the part you'd find at index 1). I also change the code to be much more reinterpret_casty, which isolates the type-punning mostly "within" the intrinsic, and which seems to match how other code uses it.
|
@swift-ci Please test Windows |
|
@swift-ci Please smoke test |
|
Test failures on Windows are due to running out of space, but the concurrency-specific tests seem to have passed. |
|
Thanks @rjmccall! LGTM |
This was referenced Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit for the cmake fix here goes to Saleem Abdulrasool.
The substantive fix is embarrassing; I didn't pay close attention to the intrinsic's argument order and just assumed that the first argument for the replacement value was the low half (the part you'd find at index 0 if it were an array), but in fact it's the high half (the part you'd find at index 1).
I also change the code to be much more reinterpret_casty, which isolates the type-punning mostly "within" the intrinsic, and which seems to match how other code I was able to find uses it.