build: correct dependencies for a unified build #34965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When not building with the standard library with the host compiler and building the check target for Swift from clean, we would mis-order the build for the BlocksRuntimeStubs which depends on the just built compiler. Ensure that CMake knows this dependency.
|
CC: @drodriguez |
|
@swift-ci please smoke test |
|
Oh, that's part of |
drodriguez
approved these changes
Dec 4, 2020
|
@swift-ci please test Windows platform |
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not building with the standard library with the host compiler and
building the check target for Swift from clean, we would mis-order the
build for the BlocksRuntimeStubs which depends on the just built
compiler. Ensure that CMake knows this dependency.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.