[Concurrency] Traffic in underlying C type rather than JobFlags. #34969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We haven't implemented any support for top-level async code yet, so reject it in effects checking rather than crashing in the SIL verifier. Fixes rdar://71512818.
Suppresses a warning about returning a C++ type from a C entrypoint, fixing rdar://71731181.
|
@swift-ci please smoke test |
ktoso
reviewed
Dec 7, 2020
| @@ -175,8 +175,7 @@ bool swift_task_removeStatusRecord(AsyncTask *task, | |||
| TaskStatusRecord *record); | |||
|
|
|||
| SWIFT_EXPORT_FROM(swift_Concurrency) SWIFT_CC(swift) | |||
| JobFlags | |||
| swift_task_getJobFlags(AsyncTask* task); | |||
| size_t swift_task_getJobFlags(AsyncTask* task); | |||
There was a problem hiding this comment.
Ah just like that, thanks @DougGregor
ktoso
reviewed
Dec 7, 2020
| JobFlags swift::swift_task_getJobFlags(AsyncTask *task) { | ||
| return task->Flags; | ||
| size_t swift::swift_task_getJobFlags(AsyncTask *task) { | ||
| return task->Flags.getOpaqueValue(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppresses a warning about returning a C++ type from a C entrypoint,
fixing rdar://71731181.