[Driver] A Pile of Nits #34991
Merged
[Driver] A Pile of Nits #34991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not doing so causes the IDE and terminals to interleave the output of the dump.
This class was relying on the caller to keep this member alive. In general, this will lead to startling memory ownership bugs if, say, the enumerators were returned from these functions. Pass it in as a parameter instead to formalize that contract.
So the compiler has a chance to see the definition for itself, rather than having to. manually force a specialization.
|
@swift-ci smoke test |
davidungar
approved these changes
Dec 7, 2020
Comment on lines
+496
to
+501
| findJobsToRecompileWhenNodesChange(const Nodes &nodes) { | ||
| std::vector<ModuleDepGraphNode *> foundDependents; | ||
| for (ModuleDepGraphNode *n : nodes) | ||
| findPreviouslyUntracedDependents(foundDependents, n); | ||
| return jobsContaining(foundDependents); | ||
| } |
There was a problem hiding this comment.
Looks like you were able to remove some template foo by moving the code to here. Is that right? If so, great!
Comment on lines
+342
to
+344
| os << "fingerprint: " << fingerprint.getValue() << ""; | ||
| else | ||
| llvm::errs() << "no fingerprint"; | ||
| os << "no fingerprint"; |
Comment on lines
+412
to
+413
| UsedDeclEnumerator(const SourceFile *SF, const DependencyTracker &depTracker, | ||
| StringRef swiftDeps) |
There was a problem hiding this comment.
What's the advantage in passing the function ref down recursively vs storing it in the instance?
Since you did it, I bet there is a good reason. Would be nice to have a comment, though.
There was a problem hiding this comment.
llvm::function_ref is non-owning. It makes me nervous to see it stored.
There was a problem hiding this comment.
D'Oh! Thank you for fixing this!
| @@ -406,26 +406,19 @@ class UsedDeclEnumerator { | |||
| StringRef swiftDeps; | |||
|
|
|||
| /// Cache these for efficiency | |||
| const DependencyKey sourceFileInterface; | |||
There was a problem hiding this comment.
I see... looks like this wasn't even used. Is that right?
Comment on lines
-491
to
-497
| return reloadAndRemarkFineGrainedDepsOnNormalExit( | ||
| FinishedCmd, cmdFailed, forRanges, DependenciesFile); | ||
| } | ||
|
|
||
| std::vector<const Job *> reloadAndRemarkFineGrainedDepsOnNormalExit( | ||
| const Job *FinishedCmd, const bool cmdFailed, const bool forRanges, | ||
| StringRef DependenciesFile) { |
|
@swift-ci test |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm::function_refis non-owning.