[nfc] Add tests for witness table size optimizations. #34995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoecarver
commented
Dec 8, 2020
|
|
||
| // CHECK-DAG: @"$sBi8_WV" = external global i8*, align 8 | ||
| // CHECK-DAG: @"$sSo5EmptyVMn" = linkonce_odr hidden constant <{ i32, i32, i32, i32, i32, i32, i32, i32 }> <{ i32 131089, i32 trunc (i64 sub (i64 ptrtoint (<{ i32, i32, i32 }>* @"$sSoMXM" to i64), i64 ptrtoint (i32* getelementptr inbounds (<{ i32, i32, i32, i32, i32, i32, i32, i32 }>, <{ i32, i32, i32, i32, i32, i32, i32, i32 }>* @"$sSo5EmptyVMn", i32 0, i32 1) to i64)) to i32), i32 trunc (i64 sub (i64 ptrtoint ([6 x i8]* @5 to i64), i64 ptrtoint (i32* getelementptr inbounds (<{ i32, i32, i32, i32, i32, i32, i32, i32 }>, <{ i32, i32, i32, i32, i32, i32, i32, i32 }>* @"$sSo5EmptyVMn", i32 0, i32 2) to i64)) to i32), i32 trunc (i64 sub (i64 ptrtoint (%swift.metadata_response (i64)* @"$sSo5EmptyVMa" to i64), i64 ptrtoint (i32* getelementptr inbounds (<{ i32, i32, i32, i32, i32, i32, i32, i32 }>, <{ i32, i32, i32, i32, i32, i32, i32, i32 }>* @"$sSo5EmptyVMn", i32 0, i32 3) to i64)) to i32), i32 trunc (i64 sub (i64 ptrtoint ({ i32, i32, i16, i16, i32 }* @"$sSo5EmptyVMF" to i64), i64 ptrtoint (i32* getelementptr inbounds (<{ i32, i32, i32, i32, i32, i32, i32, i32 }>, <{ i32, i32, i32, i32, i32, i32, i32, i32 }>* @"$sSo5EmptyVMn", i32 0, i32 4) to i64)) to i32), i32 0, i32 2, i32 0 }>, section "__TEXT,__const", align 4 | ||
| // CHECK-DAG: @"$sSo5EmptyVMf" = linkonce_odr hidden constant <{ i8**, i64, <{ i32, i32, i32, i32, i32, i32, i32, i32 }>* }> <{ i8** @"$sBi8_WV", i64 512, <{ i32, i32, i32, i32, i32, i32, i32, i32 }>* @"$sSo5EmptyVMn" }>, align 8 |
There was a problem hiding this comment.
I'm not entirely sure that this is the correct (or portable) way to test this. It would probably be sufficient just to test line 9, 14, and 19.
|
@swift-ci please smoke test Linux. |
gribozavr
approved these changes
Jan 13, 2021
zoecarver
force-pushed
the
tests/witness-table-opts
branch
from
24d32ac to
2530b95
Compare
|
@swift-ci please smoke test. |
|
@swift-ci please smoke test macOS. |
|
@swift-ci please smoke test Windows. |
|
Forgot to save the errors 😕 @swift-ci please smoke test Linux. |
zoecarver
force-pushed
the
tests/witness-table-opts
branch
from
2530b95 to
6ec369a
Compare
|
@swift-ci please smoke test. |
zoecarver
force-pushed
the
tests/witness-table-opts
branch
from
6ec369a to
8c0b8eb
Compare
|
@swift-ci please smoke test. |
|
@swift-ci please test Windows. |
|
@swift-ci please test Windows platform. |
zoecarver
force-pushed
the
tests/witness-table-opts
branch
from
8c0b8eb to
ec2e130
Compare
zoecarver
commented
Jan 31, 2021
| // that have the appropriate size/shape (for example, { i8 x 4 } -> i32). | ||
|
|
||
| // These witness tables look very differnt on Windows so it doesn't make sense | ||
| // to test them in the same file. |
There was a problem hiding this comment.
As the comment says, the witness tables appear fairly different on Windows, so I don't think it's feasible to test both platforms in the same file. If anyone disagrees, let me know and I'll investigate further / update the test.
|
@swift-ci please smoke test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.