Skip to content

[ConstraintSystem] Track adjacent type variables while inferring bindings #35007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Dec 8, 2020

Replaces InvolvesTypeVariables flag with a set of adjacent type
variables found during binding inference.

This approach is more suitable for incremental binding computation
because it allows to maintain a list of type variables that affect
ranking and check whether something has been resolved without having
to re-evaluate constraints associated with the given type variable.

…ings

Replaces `InvolvesTypeVariables` flag with a set of adjacent type
variables found during binding inference.

This approach is more suitable for incremental binding computation
because it allows to maintain a list of type variables that affect
ranking and check whether something has been resolved without having
to re-evaluate constraints associated with the given type variable.
@xedin xedin requested a review from hborla December 8, 2020 21:22
@xedin
Copy link
Contributor Author

xedin commented Dec 8, 2020

@swift-ci please test source compatibility

@xedin
Copy link
Contributor Author

xedin commented Dec 9, 2020

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Dec 9, 2020

@swift-ci please test Linux platform

@xedin
Copy link
Contributor Author

xedin commented Dec 9, 2020

@swift-ci please clean test Linux platform

@swiftlang swiftlang deleted a comment from swift-ci Dec 9, 2020
@swiftlang swiftlang deleted a comment from swift-ci Dec 9, 2020
Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xedin xedin merged commit 579274b into swiftlang:main Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants