Skip to content

Remove SILArgumentConvention::Direct_Deallocating #35009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Dec 8, 2020

When we exhaustively switch over the argument convention, we want to make sure we've handled all cases correctly, so we can't leave around extra cases that aren't clearly specified.

@atrick atrick requested a review from gottesmm December 8, 2020 21:49
@atrick
Copy link
Contributor Author

atrick commented Dec 8, 2020

@swift-ci smoke test and merge

Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@atrick
Copy link
Contributor Author

atrick commented Dec 9, 2020

@swift-ci smoke test OS X

@atrick atrick merged commit 353e6fe into swiftlang:main Dec 9, 2020
@atrick atrick deleted the remove-directdealloc branch October 19, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants