Skip to content

[ConstraintSystem] Make binding producer responsible for adjustments to the binding set #35029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 10, 2020
Merged

[ConstraintSystem] Make binding producer responsible for adjustments to the binding set #35029

merged 4 commits into from
Dec 10, 2020

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Dec 10, 2020

Since wrapping bindings into optional type based on ExpressibleByNilLiteral or
adjusting position of Any doesn't affect ranking it could be performed by
TypeVarBindingProducer instead.

xedin added 4 commits December 9, 2020 13:34
@xedin
[CSStep] Don't retain multiple copies of the same bindings just for p…
4e32132 
…rinting
@xedin
[ConstraintSystem] Handle binding nullability in producer instead of …
ef673c7 
…collector

Wrapping bindings into optional type based on presence of
an `ExpressibleByNilLiteral` conformance requirement should
be done after type variable has been selected for attempting.
Otherwise such upfront work would be wasteful since it doesn't
affect binding ranking in any way.
@xedin
[ConstraintSystem] Make binding producer responsible for attemping `A…
e678429 
…ny` last

Instead of doing that while collecting bindings, let's move `Any`
to the end of the list when type variable has been selected to be
attempted next.
@xedin
[ConstraintSystem] NFC: Extract requiresOptionalAdjustment so it co…
50cc0f0 
…uld be used for default bindings
@xedin xedin requested a review from hborla December 10, 2020 00:03
@xedin
Copy link
Contributor Author

xedin commented Dec 10, 2020

@swift-ci please smoke test compiler performance

@xedin
Copy link
Contributor Author

xedin commented Dec 10, 2020

@swift-ci please test source compatibility

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented Dec 10, 2020

@swift-ci please test source compatibility

@xedin
Copy link
Contributor Author

xedin commented Dec 10, 2020

@swift-ci please smoke test compiler performance

@swift-ci
Copy link
Contributor

Summary for main smoketest

Regressions found (see below)

Debug

debug brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 3,562,249,891,663 3,559,064,558,853 -3,185,332,810 -0.09%
LLVM.NumLLVMBytesOutput 57,171,728 57,171,660 -68 -0.0%
time.swift-driver.wall 231.4s 231.2s -216.4ms -0.09%

debug detailed

Regressed (1)
name old new delta delta_pct
Driver.ChildrenMaxRSS 6,352,988,160 6,521,096,192 168,108,032 2.65% ⛔
Improved (2)
name old new delta delta_pct
Driver.NumDriverPipePolls 525 481 -44 -8.38% ✅
Driver.NumDriverPipeReads 222 179 -43 -19.37% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (255)
name old new delta delta_pct
AST.ImportSetCacheHit 62,004 62,002 -2 -0.0%
AST.ImportSetCacheMiss 17,163 17,163 0 0.0%
AST.ImportSetFoldHit 6,214 6,214 0 0.0%
AST.ImportSetFoldMiss 10,949 10,949 0 0.0%
AST.ModuleShadowCacheHit 131 131 0 0.0%
AST.ModuleShadowCacheMiss 104 104 0 0.0%
AST.ModuleVisibilityCacheHit 492 492 0 0.0%
AST.ModuleVisibilityCacheMiss 165 165 0 0.0%
AST.NumASTBytesAllocated 1,413,176,461 1,413,127,776 -48,685 -0.0%
AST.NumASTScopeLookups 160,199 160,199 0 0.0%
AST.NumBraceStmtASTScopeExpansions 16,011 16,011 0 0.0%
AST.NumBraceStmtASTScopes 16,011 16,011 0 0.0%
AST.NumDecls 4,482 4,482 0 0.0%
AST.NumDependencies 9,759 9,759 0 0.0%
AST.NumIncrementalDependencies 0 0 0 0.0%
AST.NumIterableTypeBodyASTScopeExpansions 6,232 6,232 0 0.0%
AST.NumIterableTypeBodyASTScopes 9,477 9,477 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 9,119 9,119 0 0.0%
AST.NumLocalTypeDecls 15 15 0 0.0%
AST.NumModuleLookupClassMember 710 710 0 0.0%
AST.NumModuleLookupValue 1,944,463 1,944,301 -162 -0.01%
AST.NumObjCMethods 179 179 0 0.0%
AST.NumOperators 4 4 0 0.0%
AST.NumPrecedenceGroups 2 2 0 0.0%
AST.NumReferencedDynamicNames 22 22 0 0.0%
AST.NumReferencedMemberNames 323,004 323,004 0 0.0%
AST.NumReferencedTopLevelNames 29,827 29,827 0 0.0%
AST.NumSourceBuffers 16,040 16,040 0 0.0%
AST.NumSourceLines 115,750 115,750 0 0.0%
AST.NumSourceLinesPerSecond 31,132 30,940 -192 -0.62%
AST.NumTotalClangImportedEntities 94,291 94,372 81 0.09%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 718 718 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.MaxMallocUsage 49,969,437,760 50,081,432,096 111,994,336 0.22%
Frontend.NumInstructionsExecuted 3,562,249,891,663 3,559,064,558,853 -3,185,332,810 -0.09%
Frontend.NumProcessFailures 0 0 0 0.0%
IRGen.IRGenRequest 699 699 0 0.0%
IRGen.OptimizedIRRequest 0 0 0 0.0%
IRGen.SymbolObjectCodeRequest 0 0 0 0.0%
IRModule.NumGOTEntries 8,997 8,997 0 0.0%
IRModule.NumIRAliases 4,760 4,760 0 0.0%
IRModule.NumIRBasicBlocks 207,313 207,313 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 111,529 111,529 0 0.0%
IRModule.NumIRGlobals 122,130 122,130 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 2,329,402 2,329,402 0 0.0%
IRModule.NumIRNamedMetaData 3,495 3,495 0 0.0%
IRModule.NumIRValueSymbols 215,461 215,461 0 0.0%
LLVM.NumLLVMBytesOutput 57,171,728 57,171,660 -68 -0.0%
Parse.CodeCompletionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 6,572 6,572 0 0.0%
Parse.NumIterableDeclContextParsed 21,222 21,222 0 0.0%
Parse.ParseAbstractFunctionBodyRequest 5,746 5,746 0 0.0%
Parse.ParseMembersRequest 19,770 19,770 0 0.0%
Parse.ParseSourceFileRequest 15,993 15,993 0 0.0%
SILGen.ASTLoweringRequest 717 717 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 66,575 66,575 0 0.0%
SILModule.NumSILGenGlobalVariables 2,450 2,450 0 0.0%
SILModule.NumSILGenVtables 450 450 0 0.0%
SILModule.NumSILGenWitnessTables 4,644 4,644 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 79,047 79,047 0 0.0%
SILModule.NumSILOptGlobalVariables 2,505 2,505 0 0.0%
SILModule.NumSILOptVtables 452 452 0 0.0%
SILModule.NumSILOptWitnessTables 5,793 5,793 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 2,814 2,814 0 0.0%
SILOptimizer.LoweredSILRequest 0 0 0 0.0%
Sema.AbstractGenericSignatureRequest 392 392 0 0.0%
Sema.AccessLevelRequest 340,287 340,213 -74 -0.02%
Sema.ActorIsolationRequest 20,510 20,510 0 0.0%
Sema.AnyObjectLookupRequest 34 34 0 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 324 324 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 425,367 425,367 0 0.0%
Sema.AttachedPropertyWrappersRequest 484,966 484,966 0 0.0%
Sema.AttachedResultBuilderRequest 18,128 18,128 0 0.0%
Sema.BodyInitKindRequest 1,265 1,265 0 0.0%
Sema.CallerSideDefaultArgExprRequest 647 647 0 0.0%
Sema.CanBeAsyncHandlerRequest 4,112 4,112 0 0.0%
Sema.CheckInconsistentImplementationOnlyImportsRequest 285 285 0 0.0%
Sema.CheckRedeclarationRequest 24,330 24,330 0 0.0%
Sema.ClassAncestryFlagsRequest 2,856 2,856 0 0.0%
Sema.ClosureHasExplicitResultRequest 3,266 3,266 0 0.0%
Sema.CodeCompletionFileRequest 0 0 0 0.0%
Sema.CollectOverriddenDeclsRequest 204,020 204,259 239 0.12%
Sema.CompareDeclSpecializationRequest 15,851 15,849 -2 -0.01%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 0 0 0 0.0%
Sema.CustomAttrTypeRequest 0 0 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 1,721 1,721 0 0.0%
Sema.DefaultArgumentExprRequest 1,105 1,105 0 0.0%
Sema.DefaultArgumentInitContextRequest 13 13 0 0.0%
Sema.DefaultDefinitionTypeRequest 135 135 0 0.0%
Sema.DefaultTypeRequest 11,320 11,320 0 0.0%
Sema.DerivativeAttrOriginalDeclRequest 0 0 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 904,051 903,922 -129 -0.01%
Sema.DirectOperatorLookupRequest 57,307 57,297 -10 -0.02%
Sema.DirectPrecedenceGroupLookupRequest 16,783 16,783 0 0.0%
Sema.DynamicallyReplacedDeclRequest 28,400 28,400 0 0.0%
Sema.EnumRawTypeRequest 696 696 0 0.0%
Sema.EnumRawValuesRequest 254 254 0 0.0%
Sema.ExistentialConformsToSelfRequest 386 386 0 0.0%
Sema.ExistentialTypeSupportedRequest 335 335 0 0.0%
Sema.ExpandASTScopeRequest 152,928 152,928 0 0.0%
Sema.ExtendedNominalRequest 26,047 26,047 0 0.0%
Sema.ExtendedTypeRequest 2,391 2,391 0 0.0%
Sema.FragileFunctionKindRequest 42,330 42,329 -1 -0.0%
Sema.FunctionOperatorRequest 649 649 0 0.0%
Sema.GenericParamListRequest 128,056 128,053 -3 -0.0%
Sema.GenericSignatureRequest 69,091 69,088 -3 -0.0%
Sema.GetDestructorRequest 397 397 0 0.0%
Sema.GlobalActorAttributeRequest 22,032 22,032 0 0.0%
Sema.GlobalActorInstanceRequest 0 0 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 180 180 0 0.0%
Sema.HasCircularRawValueRequest 222 222 0 0.0%
Sema.HasDefaultInitRequest 1,416 1,416 0 0.0%
Sema.HasDynamicCallableAttributeRequest 0 0 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 19,046 19,045 -1 -0.01%
Sema.HasImplementationOnlyImportsRequest 15,993 15,993 0 0.0%
Sema.HasMemberwiseInitRequest 900 900 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 414 414 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 1,416 1,416 0 0.0%
Sema.InferredGenericSignatureRequest 3,096 3,096 0 0.0%
Sema.InheritedDeclsReferencedRequest 168,521 168,491 -30 -0.02%
Sema.InheritedProtocolsRequest 19,367 19,367 0 0.0%
Sema.InheritedTypeRequest 5,002 5,002 0 0.0%
Sema.InheritsSuperclassInitializersRequest 373 373 0 0.0%
Sema.InitKindRequest 2,382 2,382 0 0.0%
Sema.InterfaceTypeRequest 377,937 377,937 0 0.0%
Sema.IsABICompatibleOverrideRequest 3,432 3,432 0 0.0%
Sema.IsAccessorTransparentRequest 7,170 7,170 0 0.0%
Sema.IsActorRequest 9,078 9,072 -6 -0.07%
Sema.IsAsyncHandlerRequest 42,693 42,692 -1 -0.0%
Sema.IsCallableNominalTypeRequest 199 199 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDefaultActorRequest 739 739 0 0.0%
Sema.IsDynamicRequest 44,995 44,995 0 0.0%
Sema.IsFinalRequest 68,408 68,350 -58 -0.08%
Sema.IsGetterMutatingRequest 12,250 12,250 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 65,965 66,038 73 0.11%
Sema.IsObjCRequest 38,687 38,688 1 0.0%
Sema.IsSetterMutatingRequest 9,301 9,301 0 0.0%
Sema.IsStaticRequest 33,812 33,812 0 0.0%
Sema.LazyStoragePropertyRequest 19 19 0 0.0%
Sema.LookupAllConformancesInContextRequest 3,493 3,493 0 0.0%
Sema.LookupConformanceInModuleRequest 938,176 938,175 -1 -0.0%
Sema.LookupInModuleRequest 209,224 209,084 -140 -0.07%
Sema.LookupInfixOperatorRequest 2,238 2,238 0 0.0%
Sema.LookupPostfixOperatorRequest 0 0 0 0.0%
Sema.LookupPrecedenceGroupRequest 674 674 0 0.0%
Sema.LookupPrefixOperatorRequest 4 4 0 0.0%
Sema.MangleLocalTypeDeclRequest 30 30 0 0.0%
Sema.ModuleImplicitImportsRequest 303 303 0 0.0%
Sema.ModuleQualifiedLookupRequest 97,580 97,440 -140 -0.14%
Sema.NamedLazyMemberLoadSuccessCount 738,401 738,401 0 0.0%
Sema.NamingPatternRequest 6,759 6,759 0 0.0%
Sema.NeedsNewVTableEntryRequest 15,817 15,817 0 0.0%
Sema.NumAccessorBodiesSynthesized 4,593 4,593 0 0.0%
Sema.NumAccessorsSynthesized 6,676 6,676 0 0.0%
Sema.NumConformancesDeserialized 257,198 257,160 -38 -0.01%
Sema.NumConstraintScopes 590,787 590,784 -3 -0.0%
Sema.NumConstraintsConsideredForEdgeContraction 1,483,281 1,483,280 -1 -0.0%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 0 0 0 0.0%
Sema.NumDeclsDeserialized 2,145,648 2,145,505 -143 -0.01%
Sema.NumDeclsTypechecked 36,414 36,414 0 0.0%
Sema.NumGenericSignatureBuilders 30,834 30,832 -2 -0.01%
Sema.NumLazyIterableDeclContexts 274,346 274,325 -21 -0.01%
Sema.NumLazyRequirementSignatures 26,945 26,944 -1 -0.0%
Sema.NumLazyRequirementSignaturesLoaded 18,377 18,375 -2 -0.01%
Sema.NumLeafScopes 389,985 389,983 -2 -0.0%
Sema.NumTypesDeserialized 689,376 689,273 -103 -0.01%
Sema.NumUnloadedLazyIterableDeclContexts 178,678 178,717 39 0.02%
Sema.OpaqueReadOwnershipRequest 7,448 7,448 0 0.0%
Sema.OpaqueResultTypeRequest 0 0 0 0.0%
Sema.OperatorPrecedenceGroupRequest 8 8 0 0.0%
Sema.OverriddenDeclsRequest 63,772 63,923 151 0.24%
Sema.ParamSpecifierRequest 32,825 32,825 0 0.0%
Sema.PatternBindingEntryRequest 13,861 13,861 0 0.0%
Sema.PatternTypeRequest 16,877 16,877 0 0.0%
Sema.PreCheckResultBuilderRequest 0 0 0 0.0%
Sema.PrimarySourceFilesRequest 303 303 0 0.0%
Sema.PropertyWrapperBackingPropertyInfoRequest 425,145 425,145 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 425,367 425,367 0 0.0%
Sema.PropertyWrapperLValuenessRequest 0 0 0 0.0%
Sema.PropertyWrapperMutabilityRequest 17,121 17,121 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 0 0 0 0.0%
Sema.ProtocolRequiresClassRequest 1,001 1,001 0 0.0%
Sema.ProvideDefaultImplForRequest 204,020 204,259 239 0.12%
Sema.QualifiedLookupRequest 162,618 162,616 -2 -0.0%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RequirementRequest 3,857 3,857 0 0.0%
Sema.RequirementSignatureRequest 19,594 19,592 -2 -0.01%
Sema.RequiresOpaqueAccessorsRequest 36,512 36,512 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 5,982 5,982 0 0.0%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveImplicitMemberRequest 10,856 10,856 0 0.0%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 82,245 82,245 0 0.0%
Sema.ResultBuilderTypeRequest 9,800 9,800 0 0.0%
Sema.ResultTypeRequest 14,574 14,574 0 0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 391,065 391,259 194 0.05%
Sema.ScopedImportLookupRequest 0 0 0 0.0%
Sema.SelfAccessKindRequest 16,390 16,390 0 0.0%
Sema.SelfBoundsFromWhereClauseRequest 49,504 49,503 -1 -0.0%
Sema.SemanticMembersRequest 444 444 0 0.0%
Sema.SetterAccessLevelRequest 3,464 3,464 0 0.0%
Sema.SimpleDidSetRequest 61,329 61,381 52 0.08%
Sema.SpecializeAttrTargetDeclRequest 86 86 0 0.0%
Sema.StorageImplInfoRequest 42,404 42,404 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 687 687 0 0.0%
Sema.StoredPropertiesRequest 11,123 11,123 0 0.0%
Sema.StructuralTypeRequest 42 42 0 0.0%
Sema.SuperclassDeclRequest 12,693 12,693 0 0.0%
Sema.SuperclassTypeRequest 975 975 0 0.0%
Sema.SynthesizeAccessorRequest 6,676 6,676 0 0.0%
Sema.SynthesizeDefaultInitRequest 136 136 0 0.0%
Sema.SynthesizeMainFunctionRequest 401 401 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 146 146 0 0.0%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeCheckASTNodeAtLocRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 12,199 12,199 0 0.0%
Sema.TypeCheckSourceFileRequest 699 699 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 910 910 0 0.0%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 253 253 0 0.0%
Sema.USRGenerationRequest 237,055 237,285 230 0.1%
Sema.UnderlyingTypeDeclsReferencedRequest 5,937 5,920 -17 -0.29%
Sema.UnderlyingTypeRequest 424 424 0 0.0%
Sema.UnqualifiedLookupRequest 129,231 129,231 0 0.0%
Sema.ValidatePrecedenceGroupRequest 3,848 3,848 0 0.0%
Sema.ValueWitnessRequest 2,278 2,278 0 0.0%
TBDGen.GenerateTBDRequest 0 0 0 0.0%
TBDGen.PublicSymbolsRequest 699 699 0 0.0%
TBDGen.SymbolSourceMapRequest 0 0 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 1,631,660,099,101 1,629,676,966,009 -1,983,133,092 -0.12%
LLVM.NumLLVMBytesOutput 60,775,400 60,775,780 380 0.0%
time.swift-driver.wall 301.7s 302.6s 928.8ms 0.31%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (258)
name old new delta delta_pct
AST.ImportSetCacheHit 38,407 38,407 0 0.0%
AST.ImportSetCacheMiss 1,599 1,599 0 0.0%
AST.ImportSetFoldHit 879 879 0 0.0%
AST.ImportSetFoldMiss 720 720 0 0.0%
AST.ModuleShadowCacheHit 71 71 0 0.0%
AST.ModuleShadowCacheMiss 56 56 0 0.0%
AST.ModuleVisibilityCacheHit 236 236 0 0.0%
AST.ModuleVisibilityCacheMiss 51 51 0 0.0%
AST.NumASTBytesAllocated 218,492,874 218,491,414 -1,460 -0.0%
AST.NumASTScopeLookups 117,161 117,161 0 0.0%
AST.NumBraceStmtASTScopeExpansions 15,285 15,285 0 0.0%
AST.NumBraceStmtASTScopes 15,285 15,285 0 0.0%
AST.NumDecls 4,482 4,482 0 0.0%
AST.NumDependencies 620 620 0 0.0%
AST.NumIncrementalDependencies 0 0 0 0.0%
AST.NumIterableTypeBodyASTScopeExpansions 2,175 2,175 0 0.0%
AST.NumIterableTypeBodyASTScopes 2,342 2,342 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 526 526 0 0.0%
AST.NumLocalTypeDecls 15 15 0 0.0%
AST.NumModuleLookupClassMember 676 676 0 0.0%
AST.NumModuleLookupValue 944,195 944,195 0 0.0%
AST.NumObjCMethods 179 179 0 0.0%
AST.NumOperators 4 4 0 0.0%
AST.NumPrecedenceGroups 2 2 0 0.0%
AST.NumReferencedDynamicNames 0 0 0 0.0%
AST.NumReferencedMemberNames 0 0 0 0.0%
AST.NumReferencedTopLevelNames 0 0 0 0.0%
AST.NumSourceBuffers 706 706 0 0.0%
AST.NumSourceLines 115,750 115,750 0 0.0%
AST.NumSourceLinesPerSecond 3,684 3,665 -19 -0.52%
AST.NumTotalClangImportedEntities 15,754 15,754 0 0.0%
Driver.ChildrenMaxRSS 8,040,794,112 8,087,709,696 46,915,584 0.58%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 20 20 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumDriverPipePolls 223 221 -2 -0.9%
Driver.NumDriverPipeReads 203 201 -2 -0.99%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.MaxMallocUsage 6,833,231,784 6,894,972,312 61,740,528 0.9%
Frontend.NumInstructionsExecuted 1,631,660,099,101 1,629,676,966,009 -1,983,133,092 -0.12%
Frontend.NumProcessFailures 0 0 0 0.0%
IRGen.IRGenRequest 0 0 0 0.0%
IRGen.OptimizedIRRequest 0 0 0 0.0%
IRGen.SymbolObjectCodeRequest 0 0 0 0.0%
IRModule.NumGOTEntries 6,984 6,984 0 0.0%
IRModule.NumIRAliases 3,666 3,666 0 0.0%
IRModule.NumIRBasicBlocks 175,193 175,193 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 83,485 83,485 0 0.0%
IRModule.NumIRGlobals 102,538 102,538 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 1,510,323 1,510,323 0 0.0%
IRModule.NumIRNamedMetaData 3,495 3,495 0 0.0%
IRModule.NumIRValueSymbols 175,600 175,600 0 0.0%
LLVM.NumLLVMBytesOutput 60,775,400 60,775,780 380 0.0%
Parse.CodeCompletionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 6,570 6,570 0 0.0%
Parse.NumIterableDeclContextParsed 2,403 2,403 0 0.0%
Parse.ParseAbstractFunctionBodyRequest 5,608 5,608 0 0.0%
Parse.ParseMembersRequest 8 8 0 0.0%
Parse.ParseSourceFileRequest 699 699 0 0.0%
SILGen.ASTLoweringRequest 18 18 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 32,376 32,376 0 0.0%
SILModule.NumSILGenGlobalVariables 2,440 2,440 0 0.0%
SILModule.NumSILGenVtables 250 250 0 0.0%
SILModule.NumSILGenWitnessTables 2,207 2,207 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 27,312 27,312 0 0.0%
SILModule.NumSILOptGlobalVariables 3,157 3,157 0 0.0%
SILModule.NumSILOptVtables 308 308 0 0.0%
SILModule.NumSILOptWitnessTables 2,262 2,262 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 72 72 0 0.0%
SILOptimizer.LoweredSILRequest 0 0 0 0.0%
Sema.AbstractGenericSignatureRequest 383 383 0 0.0%
Sema.AccessLevelRequest 38,479 38,479 0 0.0%
Sema.ActorIsolationRequest 12,158 12,158 0 0.0%
Sema.AnyObjectLookupRequest 34 34 0 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 212 212 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 420,107 420,107 0 0.0%
Sema.AttachedPropertyWrappersRequest 463,075 463,075 0 0.0%
Sema.AttachedResultBuilderRequest 17,083 17,083 0 0.0%
Sema.BodyInitKindRequest 1,145 1,145 0 0.0%
Sema.CallerSideDefaultArgExprRequest 647 647 0 0.0%
Sema.CanBeAsyncHandlerRequest 3,219 3,219 0 0.0%
Sema.CheckInconsistentImplementationOnlyImportsRequest 18 18 0 0.0%
Sema.CheckRedeclarationRequest 24,400 24,400 0 0.0%
Sema.ClassAncestryFlagsRequest 1,064 1,064 0 0.0%
Sema.ClosureHasExplicitResultRequest 3,260 3,260 0 0.0%
Sema.CodeCompletionFileRequest 0 0 0 0.0%
Sema.CollectOverriddenDeclsRequest 0 0 0 0.0%
Sema.CompareDeclSpecializationRequest 13,478 13,478 0 0.0%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 0 0 0 0.0%
Sema.CustomAttrTypeRequest 0 0 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 1,101 1,101 0 0.0%
Sema.DefaultArgumentExprRequest 1,105 1,105 0 0.0%
Sema.DefaultArgumentInitContextRequest 0 0 0 0.0%
Sema.DefaultDefinitionTypeRequest 51 51 0 0.0%
Sema.DefaultTypeRequest 10,923 10,923 0 0.0%
Sema.DerivativeAttrOriginalDeclRequest 0 0 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 793,354 793,370 16 0.0%
Sema.DirectOperatorLookupRequest 43,316 43,316 0 0.0%
Sema.DirectPrecedenceGroupLookupRequest 15,915 15,915 0 0.0%
Sema.DynamicallyReplacedDeclRequest 18,837 18,837 0 0.0%
Sema.EnumRawTypeRequest 222 222 0 0.0%
Sema.EnumRawValuesRequest 241 241 0 0.0%
Sema.ExistentialConformsToSelfRequest 119 119 0 0.0%
Sema.ExistentialTypeSupportedRequest 167 167 0 0.0%
Sema.ExpandASTScopeRequest 75,439 75,439 0 0.0%
Sema.ExtendedNominalRequest 1,218 1,218 0 0.0%
Sema.ExtendedTypeRequest 1,218 1,218 0 0.0%
Sema.FragileFunctionKindRequest 26,222 26,222 0 0.0%
Sema.FunctionOperatorRequest 82 82 0 0.0%
Sema.GenericParamListRequest 29,857 29,857 0 0.0%
Sema.GenericSignatureRequest 25,369 25,369 0 0.0%
Sema.GetDestructorRequest 293 293 0 0.0%
Sema.GlobalActorAttributeRequest 12,963 12,963 0 0.0%
Sema.GlobalActorInstanceRequest 0 0 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 168 168 0 0.0%
Sema.HasCircularRawValueRequest 222 222 0 0.0%
Sema.HasDefaultInitRequest 794 794 0 0.0%
Sema.HasDynamicCallableAttributeRequest 0 0 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 7,044 7,044 0 0.0%
Sema.HasImplementationOnlyImportsRequest 699 699 0 0.0%
Sema.HasMemberwiseInitRequest 544 544 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 279 279 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 794 794 0 0.0%
Sema.InferredGenericSignatureRequest 1,329 1,329 0 0.0%
Sema.InheritedDeclsReferencedRequest 27,162 27,162 0 0.0%
Sema.InheritedProtocolsRequest 1,927 1,927 0 0.0%
Sema.InheritedTypeRequest 3,406 3,406 0 0.0%
Sema.InheritsSuperclassInitializersRequest 181 181 0 0.0%
Sema.InitKindRequest 1,351 1,351 0 0.0%
Sema.InterfaceTypeRequest 78,158 78,158 0 0.0%
Sema.IsABICompatibleOverrideRequest 3,384 3,384 0 0.0%
Sema.IsAccessorTransparentRequest 6,109 6,109 0 0.0%
Sema.IsActorRequest 1,388 1,388 0 0.0%
Sema.IsAsyncHandlerRequest 16,881 16,881 0 0.0%
Sema.IsCallableNominalTypeRequest 199 199 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDefaultActorRequest 407 407 0 0.0%
Sema.IsDynamicRequest 30,583 30,583 0 0.0%
Sema.IsFinalRequest 24,126 24,126 0 0.0%
Sema.IsGetterMutatingRequest 9,285 9,285 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 49,785 49,785 0 0.0%
Sema.IsObjCRequest 26,470 26,470 0 0.0%
Sema.IsSetterMutatingRequest 8,745 8,745 0 0.0%
Sema.IsStaticRequest 13,906 13,906 0 0.0%
Sema.LazyStoragePropertyRequest 11 11 0 0.0%
Sema.LookupAllConformancesInContextRequest 2,234 2,234 0 0.0%
Sema.LookupConformanceInModuleRequest 1,022,269 1,022,440 171 0.02%
Sema.LookupInModuleRequest 61,104 61,104 0 0.0%
Sema.LookupInfixOperatorRequest 1,726 1,726 0 0.0%
Sema.LookupPostfixOperatorRequest 0 0 0 0.0%
Sema.LookupPrecedenceGroupRequest 666 666 0 0.0%
Sema.LookupPrefixOperatorRequest 2 2 0 0.0%
Sema.MangleLocalTypeDeclRequest 15 15 0 0.0%
Sema.ModuleImplicitImportsRequest 18 18 0 0.0%
Sema.ModuleQualifiedLookupRequest 8,667 8,667 0 0.0%
Sema.NamedLazyMemberLoadSuccessCount 240,734 240,734 0 0.0%
Sema.NamingPatternRequest 2,114 2,114 0 0.0%
Sema.NeedsNewVTableEntryRequest 12,701 12,701 0 0.0%
Sema.NumAccessorBodiesSynthesized 4,550 4,550 0 0.0%
Sema.NumAccessorsSynthesized 4,618 4,618 0 0.0%
Sema.NumConformancesDeserialized 75,241 75,241 0 0.0%
Sema.NumConstraintScopes 571,854 571,854 0 0.0%
Sema.NumConstraintsConsideredForEdgeContraction 1,474,493 1,474,493 0 0.0%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 0 0 0 0.0%
Sema.NumDeclsDeserialized 216,715 216,715 0 0.0%
Sema.NumDeclsTypechecked 36,524 36,524 0 0.0%
Sema.NumGenericSignatureBuilders 4,872 4,872 0 0.0%
Sema.NumLazyIterableDeclContexts 26,788 26,788 0 0.0%
Sema.NumLazyRequirementSignatures 1,948 1,948 0 0.0%
Sema.NumLazyRequirementSignaturesLoaded 1,489 1,489 0 0.0%
Sema.NumLeafScopes 374,749 374,749 0 0.0%
Sema.NumTypesDeserialized 110,342 110,342 0 0.0%
Sema.NumUnloadedLazyIterableDeclContexts 16,841 16,841 0 0.0%
Sema.OpaqueReadOwnershipRequest 5,066 5,066 0 0.0%
Sema.OpaqueResultTypeRequest 0 0 0 0.0%
Sema.OperatorPrecedenceGroupRequest 4 4 0 0.0%
Sema.OverriddenDeclsRequest 24,784 24,784 0 0.0%
Sema.ParamSpecifierRequest 19,561 19,561 0 0.0%
Sema.PatternBindingEntryRequest 8,590 8,590 0 0.0%
Sema.PatternTypeRequest 11,602 11,602 0 0.0%
Sema.PreCheckResultBuilderRequest 0 0 0 0.0%
Sema.PrimarySourceFilesRequest 18 18 0 0.0%
Sema.PropertyWrapperBackingPropertyInfoRequest 419,957 419,957 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 420,107 420,107 0 0.0%
Sema.PropertyWrapperLValuenessRequest 0 0 0 0.0%
Sema.PropertyWrapperMutabilityRequest 14,083 14,083 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 0 0 0 0.0%
Sema.ProtocolRequiresClassRequest 203 203 0 0.0%
Sema.ProvideDefaultImplForRequest 0 0 0 0.0%
Sema.QualifiedLookupRequest 104,103 104,103 0 0.0%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RequirementRequest 2,490 2,490 0 0.0%
Sema.RequirementSignatureRequest 1,743 1,743 0 0.0%
Sema.RequiresOpaqueAccessorsRequest 32,237 32,237 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 4,464 4,464 0 0.0%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveImplicitMemberRequest 7,509 7,509 0 0.0%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 48,044 48,044 0 0.0%
Sema.ResultBuilderTypeRequest 8,755 8,755 0 0.0%
Sema.ResultTypeRequest 9,473 9,473 0 0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 49,103 49,103 0 0.0%
Sema.ScopedImportLookupRequest 0 0 0 0.0%
Sema.SelfAccessKindRequest 8,292 8,292 0 0.0%
Sema.SelfBoundsFromWhereClauseRequest 10,437 10,437 0 0.0%
Sema.SemanticMembersRequest 283 283 0 0.0%
Sema.SetterAccessLevelRequest 2,905 2,905 0 0.0%
Sema.SimpleDidSetRequest 7,896 7,896 0 0.0%
Sema.SpecializeAttrTargetDeclRequest 39 39 0 0.0%
Sema.StorageImplInfoRequest 35,293 35,293 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 450 450 0 0.0%
Sema.StoredPropertiesRequest 3,367 3,367 0 0.0%
Sema.StructuralTypeRequest 10 10 0 0.0%
Sema.SuperclassDeclRequest 1,683 1,683 0 0.0%
Sema.SuperclassTypeRequest 434 434 0 0.0%
Sema.SynthesizeAccessorRequest 4,618 4,618 0 0.0%
Sema.SynthesizeDefaultInitRequest 103 103 0 0.0%
Sema.SynthesizeMainFunctionRequest 250 250 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 90 90 0 0.0%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeCheckASTNodeAtLocRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 12,123 12,123 0 0.0%
Sema.TypeCheckSourceFileRequest 699 699 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 613 613 0 0.0%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 116 116 0 0.0%
Sema.USRGenerationRequest 8,581 8,581 0 0.0%
Sema.UnderlyingTypeDeclsReferencedRequest 1,015 1,015 0 0.0%
Sema.UnderlyingTypeRequest 139 139 0 0.0%
Sema.UnqualifiedLookupRequest 61,585 61,585 0 0.0%
Sema.ValidatePrecedenceGroupRequest 3,838 3,838 0 0.0%
Sema.ValueWitnessRequest 1,192 1,192 0 0.0%
TBDGen.GenerateTBDRequest 0 0 0 0.0%
TBDGen.PublicSymbolsRequest 18 18 0 0.0%
TBDGen.SymbolSourceMapRequest 0 0 0 0.0%

@xedin
Copy link
Contributor Author

xedin commented Dec 10, 2020

Ok, some more heap use in debug mode I think we could leave with until the refactoring of potential bindings is complete which would offset that.

@xedin
Copy link
Contributor Author

xedin commented Dec 10, 2020

@swift-ci please clean test

@xedin xedin merged commit 23b8dba into swiftlang:main Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xedin @swift-ci @hborla