[SourceKit] Fix flakey VFS completion tests #35042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
force-pushed
the
fix-flakey-vfs-tests
branch
from
3dd5f3b to
fd2cb30
Compare
bnbarham
commented
Dec 10, 2020
| // RUN: -req=complete -pos=2:9 -pass-as-sourcetext -vfs-files=%t/VFS/Main.swift=@%s,%t/VFS/Library.swift=@%S/Inputs/checkdeps/MyProject_mod/Library.swift %t/VFS/Main.swift -- -target %target-triple %t/VFS/Main.swift %t/VFS/LibraryExt.swift %t/VFS/Library.swift == \ | ||
|
|
||
| // RUN: -shell -- echo "### Keep" == \ | ||
| // RUN: -shell -- sleep ${SLEEP_TIME} == \ | ||
| // RUN: -req=global-config -req-opts=completion_check_dependency_interval=0 == \ |
There was a problem hiding this comment.
Not strictly required but I thought it made the behaviour we're emulating slightly more obvious, let me know if you'd prefer it removed.
These tests relied on timing between completion runs in order to check that fast completion was working properly for completions in VFS files. That is, they would assume that two runs happening one after another without a sleep inbetween would always run fast completion. However, that's not necessarily the case and there have been cases where a dependency check happens despite its interval being fairly long (multi-second). This change emulates the same behaviour by changing the interval between 0/100, which should prevent any timing issues. Resolves rdar://72144331
bnbarham
force-pushed
the
fix-flakey-vfs-tests
branch
from
fd2cb30 to
68f89d4
Compare
|
@swift-ci please test |
rintaro
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests relied on timing between completion runs in order to check
that fast completion was working properly for completions in VFS files.
That is, they would assume that two runs happening one after another
without a sleep inbetween would always run fast completion.
However, that's not necessarily the case and there have been cases where
a dependency check happens despite its interval being fairly long
(multi-second).
This change simulates the same behaviour by changing the interval
between 0/100, which should prevent any timing issues.
Resolves rdar://72144331