[sil-combine] Use high level ARC APIs instead of low level ARC APIs in a few cases to make code work in ossa and non-ossa. #35046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a few cases to make code work in ossa and non-ossa.
gottesmm
commented
Dec 11, 2020
| @@ -1416,7 +1418,7 @@ static void emitMatchingRCAdjustmentsForCall(ApplyInst *Call, SILValue OnX) { | |||
|
|
|||
| // Emit a retain for the @owned return. | |||
| SILBuilderWithScope Builder(Call); | |||
| Builder.createRetainValue(Call->getLoc(), OnX, Builder.getDefaultAtomicity()); | |||
| OnX = Builder.emitCopyValueOperation(Call->getLoc(), OnX); | |||
There was a problem hiding this comment.
One thing to be aware of is that when we compile without ownership, we return the retain_value's operand here.
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just a few cases where I could 1-1 translate the APIs to do the correct thing in both OSSA and non-OSSA.