[Diagnostics] Special case assignment between nominal types with optional promotion #35072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
…onal promotion Skip fixing situation where source and destination of assignment are both nominal types with different optionality until restriction is attempted. Otherwise fix could be too greedy and diagnose valid code if all of the types are known in advance. Resolves: SR-13951 Resolves: rdar://problem/72166791
|
@swift-ci please smoke test |
LucianoPAlmeida
approved these changes
Dec 12, 2020
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jan 7, 2021
…optional This is a follow-up to swiftlang#35072. Let's wait until both sides are equally optional before attempting `.rawValue` fix, otherwise there is a risk that a valid code would get diagnosed. Extend test coverage of possible `.rawValue` situations to contextual and argument positions to make sure that valid code is accepted. Resolves: SR-13951
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jan 7, 2021
…optional This is a follow-up to swiftlang#35072. Let's wait until both sides are equally optional before attempting `.rawValue` fix, otherwise there is a risk that a valid code would get diagnosed. Extend test coverage of possible `.rawValue` situations to contextual and argument positions to make sure that valid code is accepted. Resolves: SR-13951 (cherry picked from commit 2641554)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip fixing situation where source and destination of assignment are both
nominal types with different optionality until restriction is attempted.
Otherwise fix could be too greedy and diagnose valid code if all of the
types are known in advance.
Resolves: SR-13951
Resolves: rdar://problem/72166791