Skip to content

SE-0308: Postfix '#if' expression #35097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2021
Merged

SE-0308: Postfix '#if' expression #35097

merged 1 commit into from
Apr 29, 2021

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Dec 15, 2020 •
edited
Loading

This allows:

foo()
#if FLAG
  .bar()
#else
  .baz()
#endif
  .finalize()

@rintaro
Copy link
Member Author

rintaro commented Dec 15, 2020

@swift-ci Please Build Toolchain macOS Platform

@rintaro rintaro marked this pull request as draft December 15, 2020 18:53
@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - 351344e4fb4b8c5d2ee13fe6247656318f72924a

Install command
tar -zxf swift-PR-35097-809-osx.tar.gz --directory ~/

@rintaro rintaro force-pushed the parse-ifconfig-postfixexpr branch from 351344e to b9de67c Compare December 15, 2020 22:56
@rintaro
Copy link
Member Author

rintaro commented Dec 15, 2020

@swift-ci Please Build Toolchain macOS Platform

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - b9de67cffe3fe21997f8db55c17b387424b4f9a7

Install command
tar -zxf swift-PR-35097-810-osx.tar.gz --directory ~/

@rintaro
Copy link
Member Author

rintaro commented Dec 16, 2020

@swift-ci Please Build Toolchain macOS Platform

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - 844af79794f4059ac9be3169cf9559d8d78633cc

Install command
tar -zxf swift-PR-35097-811-osx.tar.gz --directory ~/

@rintaro rintaro force-pushed the parse-ifconfig-postfixexpr branch from 844af79 to 07d56c4 Compare December 18, 2020 04:09
@rintaro
Copy link
Member Author

rintaro commented Dec 18, 2020

@swift-ci Please Build Toolchain macOS Platform

1 similar comment
@rintaro
Copy link
Member Author

rintaro commented Dec 18, 2020

@swift-ci Please Build Toolchain macOS Platform

@rintaro
Copy link
Member Author

rintaro commented Dec 18, 2020

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Dec 18, 2020

@swift-ci Please test source compatibility

@rintaro
Copy link
Member Author

rintaro commented Dec 21, 2020

@swift-ci Please test

1 similar comment
@rintaro
Copy link
Member Author

rintaro commented Dec 21, 2020

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Dec 21, 2020

@swift-ci Please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b6a65236970b7737563cf9840fcbd8df920e7ff6

@rintaro rintaro force-pushed the parse-ifconfig-postfixexpr branch from 1de6c0a to 11491d9 Compare December 22, 2020 02:44
@rintaro rintaro added the swift evolution pending discussion Flag → feature: A feature that has a Swift evolution proposal currently in review label Jan 25, 2021
@rintaro rintaro changed the title [DoNotMerge][Experimental] Postfix '#if' expression [DoNotMerge] Postfix '#if' expression Feb 1, 2021
@rintaro rintaro mentioned this pull request Feb 1, 2021
Merged
@rintaro rintaro force-pushed the parse-ifconfig-postfixexpr branch from 11491d9 to 91241a1 Compare March 1, 2021 23:04
@rintaro rintaro changed the title [DoNotMerge] Postfix '#if' expression SE-0308: Postfix '#if' expression Apr 29, 2021
@rintaro rintaro added swift evolution approved Flag → feature: A feature that was approved through the Swift evolution process and removed swift evolution pending discussion Flag → feature: A feature that has a Swift evolution proposal currently in review labels Apr 29, 2021
@rintaro
Copy link
Member Author

rintaro commented Apr 29, 2021

@swift-ci Please test

@rintaro rintaro marked this pull request as ready for review April 29, 2021 04:16
@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 91241a123584b7f78106edfffba5f494d558bf6b

@rintaro
[Parse] Postfix '#if' expression
ce87bf7 
Implement postfix ifconfig expression which expands '#if' functionality
to postfix member reference expressions.

rdar://problem/51690082
@rintaro rintaro force-pushed the parse-ifconfig-postfixexpr branch from 91241a1 to ce87bf7 Compare April 29, 2021 16:17
@rintaro
Copy link
Member Author

rintaro commented Apr 29, 2021

swiftlang/swift-syntax#281
@swift-ci Please smoke test

This was referenced Apr 29, 2021
Merged
Merged
@rintaro rintaro merged commit f6125c0 into swiftlang:main Apr 29, 2021
@rintaro rintaro deleted the parse-ifconfig-postfixexpr branch April 29, 2021 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
swift evolution approved Flag → feature: A feature that was approved through the Swift evolution process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @swift-ci