Skip to content

[Runtime] Add SWIFT_ALWAYS_INLINE to various refcounting helpers. #35122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Dec 16, 2020

Clang has decided not to inline certain functions on the refcounting fast paths, so we need to convince it otherwise.

rdar://problem/72150908

Clang has decided not to inline certain functions on the refcounting fast paths, so we need to convince it otherwise.

rdar://problem/72150908
@mikeash mikeash requested a review from Catfish-Man December 16, 2020 15:29
@mikeash
Copy link
Contributor Author

mikeash commented Dec 16, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 4054521

@mikeash
Copy link
Contributor Author

mikeash commented Dec 16, 2020

@swift-ci please test linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4054521

@nate-chandler
Copy link
Contributor

@swift-ci please test windows platform

@nate-chandler
Copy link
Contributor

@swift-ci please test macos platform

@mikeash
Copy link
Contributor Author

mikeash commented Dec 18, 2020

@swift-ci please test windows platform

Copy link
Contributor

@Catfish-Man Catfish-Man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeash mikeash merged commit 6efd52d into swiftlang:main Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants