[CodeCompletion][Sema] Refine logic that ignores missing arguments after the code completion position when solving #35136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
xedin
reviewed
Dec 17, 2020
nathawes
force-pushed
the
dont-allow-missing-args-if-trailing-and-not-function-type
branch
from
1ca0d69 to
c9fe157
Compare
|
@swift-ci please test |
nathawes
commented
Feb 19, 2021
nathawes
force-pushed
the
dont-allow-missing-args-if-trailing-and-not-function-type
branch
from
c9fe157 to
eefdce5
Compare
|
@swift-ci please test |
xedin
approved these changes
Feb 19, 2021
…ter the code completion position when solving If the completion loc was in a trailing closure arg, it only makes sense to ignore later missing args if they have function type, as there's no way for the user to complete the call for overload being matched otherwise. Also fix a bug where we were incorrectly penalizing solutions with holes that were ultimately due to missing arguments after the completion position. Resolves rdar://problem/72412302
nathawes
force-pushed
the
dont-allow-missing-args-if-trailing-and-not-function-type
branch
from
eefdce5 to
cdcaa11
Compare
|
@swift-ci please test and merge |
|
@swift-ci please test and merge |
nathawes
deleted the
dont-allow-missing-args-if-trailing-and-not-function-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the completion loc was in a trailing closure arg, it only makes sense to ignore later missing args if they can accept a closure argument (e.g. function type,
Any, or generics), as there's no way for the user to complete the call for the overload being matched otherwise.This also fix a bug where we were incorrectly penalizing solutions with holes that were ultimately due to missing arguments after the completion position (e.g. if the missing argument corresponded to a generic parameter), and ended up excluding those solutions from the results.
Resolves rdar://problem/72412302