[stdlib] Implement partition API change (SE-0120) #3517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natecook1000
added
the
swift evolution pending discussion
| @@ -907,16 +907,20 @@ func checkPartition_${'Predicate' if predicate else 'WhereElementIsComparable'}( | |||
|
|
|||
| var c = makeWrappedCollectionWithComparableElement(elements) | |||
| % end | |||
|
|
|||
| let pivotElt = c.first | |||
natecook1000
force-pushed
the
nc-SE-0120
branch
4 times, most recently
from
a299fdc to
c46d57b
Compare
Special thanks to @aschwaighofer for help with these tests and fix-its!
natecook1000
added
swift evolution approved
|
@swift-ci Please test |
| lessImpl: ((Int, Int) -> Bool), | ||
| verifyOrder: Bool | ||
| ) { | ||
| let extract = extractValue |
There was a problem hiding this comment.
Can you remove the extract variable and just use extractValue?
Adds a dispatch test for partition(by:), since it's now a protocol requirement. Also adds a new logging collection wrapper that only logs when _withUnsafeMutableBufferPointerIfSupported is called -- any calls to this method from dispatched methods are uncounted by the standard logging wrappers.
|
@swift-ci Please test |
|
@swift-ci Please test OS X platform |
| public mutating func _withUnsafeMutableBufferPointerIfSupported<R>( | ||
| _ body: @noescape (UnsafeMutablePointer<Iterator.Element>, Int) throws -> R | ||
| ) rethrows -> R? { | ||
| print("Log._withUnsafeMutableBufferPointerIfSupported[selfType] += 1") |
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
This implements the partition API changes proposed in SE-0120.
Please don't merge until/unless the proposal is accepted.
Resolved bug number: (SR-1965)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.