[sil-combine] Enable dead alloc_ref elim for ossa. #35182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was just looking for an alloc_ref that only has dealloc_ref, set_deallocating, fix_lifetime users.
gottesmm
commented
Dec 21, 2020
| if (AR->getFunction()->hasOwnership()) | ||
| return nullptr; | ||
|
|
||
| if (!AR) |
There was a problem hiding this comment.
I don't know why this check is here. Seems like a mistake. A visitor should never be passing in a null value.
|
@swift-ci smoke test |
meg-gupta
approved these changes
Dec 21, 2020
|
I was thinking about that. I want to make sure @atrick is cool with it first. |
|
@gottesmm @meg-gupta fyi, it's fine to eliminate I have no problem with the test subdirectories matching the source subdirectories. |
|
Ok. SGTM! I was just porting. I am trying to slim down my large patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was just looking for an alloc_ref that only has dealloc_ref,
set_deallocating, fix_lifetime users.