[Property Wrappers] Fix a few corner cases where property wrappers with nonmutating setters fail in DI #35218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the setter type before attempting to emit a load in the case where the setter is nonmutating and must capture self by value.
is in an init or if the wrapped var is a local variable.
in adjustSelfTypeForMember in CSApply.
LifetimeChecker::shouldEmitError in order to avoid incorrectly populating EmittedErrorLocs when no error is emitted. This fixes a few corner cases where DI would error out or crash while assigning to a wrapped property with a nonmutating setter.
|
@swift-ci please test source compatibility |
1 similar comment
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility release |
1 similar comment
|
@swift-ci please test source compatibility release |
slavapestov
approved these changes
Jan 8, 2021
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assign_by_wrapperinstruction, substitute generic arguments in the setter type before emitting code to capture the base object. Otherwise, the setter would be incorrectly applied to the address ofselfinstead of loading the value ifselfis a generic type and the setter isnonmutating.LifetimeChecker::shouldEmitErrorin order to avoid incorrectly recording a non-erroneous location as erroneous.These changes correct a compiler crash that occurred when a generic type has a property wrapper with a nonmutating setter that is re-assigned in the initializer, e.g.
This also allows out-of-line initialization via wrapped value when a struct contains a reference type property wrapper.
Resolves: rdar://67445345
Resolves: rdar://66561517