Fix CSE::processOpenExistentialRef #35265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
Build failed |
gottesmm
reviewed
Jan 5, 2021
|
Build failed |
|
ReactiveCocoa passed here - https://ci.swift.org/job/swift-PR-source-compat-suite/5160/ |
PR#34895 changed CSE to have common object for OpenedArchetypesTracker and Cloner. CSE however frees and allocates instructions and this can result in the Cloner having stale state for deleted instructions whose address may be re-used while creating new instructions. Using a local object avoids this.
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test Linux Platform |
1 similar comment
|
@swift-ci smoke test Linux Platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR#34895 changed CSE to have common object for OpenedArchetypesTracker and Cloner.
CSE however frees and allocates instructions and this can result in the Cloner having stale state for deleted instructions whose address may be re-used while creating new instructions. Using a local object avoids this.