Platform: add a cplusplus requirement to XAudio
#35268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases when building the `XAudio` module, we would end up going
down C++ paths:
```
C:\Program Files (x86)\Windows Kits\10\/Include/10.0.17763.0/um/xaudio2.h:61:26: error: 'uuid' attribute is not supported in C
interface __declspec(uuid("2B02E3CF-2E0B-4ec3-BE45-1B2A3FE7210D")) IXAudio2;
^
<module-includes>:29:10: note: in file included from <module-includes>:29:
^
```
Although this works with newer SDKs, it does not work with older SDKs.
Filter out the module for the time being with a requirement on `C++`.
This should be possible to use with `-enable-cxx-interop`.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
|
Well that's stinky. I don't mind the newer SDK requirement, but I'd like to avoid build flags until the package manager gets a safe way to define them per package. I'd like to keep projects working with just swift build and nothing else. I'll look into XAudio1 and see what it's expected end of life might be and if it meets all the requirements for reasonably modern spacial audio, I'm sure it probably does. If the newest Xbox supports it then that's at least 5 more years of support. |
|
Sure, but I don't think its fair to break the modules for everyone else. You can workaround it by using: swiftSettings: [
.unsafeFlags(["-Xfrontend", "-enable-cxx-interop"])
]in |
|
@swift-ci please smoke test macOS platform |
|
@kastiglione - hey, mind taking a look at this failure? The failure is interesting, I've been seeing this elsewhere as well, where |
|
|
That compilation error is fixed in swiftlang/llvm-project#2281 |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases when building the
XAudiomodule, we would end up goingdown C++ paths:
Although this works with newer SDKs, it does not work with older SDKs.
Filter out the module for the time being with a requirement on
C++.This should be possible to use with
-enable-cxx-interop.Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.