-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Replace llvm::MD5 with SipHash-2-4 #35269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci test compiler performance |
Compilation-performance test failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine. I wonder how can we test or reassure ourselves that:
- The new hash has similar or better collision performance than the old, and
- The implementation of the new algorithm computes the correct values?
@swift-ci test compiler performance |
Compilation-performance test failed |
@swift-ci test compiler performance |
@swift-ci test compiler performance |
Compilation-performance test failed |
@swift-ci test compiler performance |
Summary for main fullUnexpected test results, excluded stats for RxCocoa Regressions found (see below) Debug-batchdebug-batch briefRegressed (0)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
debug-batch detailedRegressed (2)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (252)
Releaserelease briefRegressed (0)
Improved (0)
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
release detailedRegressed (0)
Improved (2)
Unchanged (delta < 1.0% or delta < 100.0ms) (252)
|
@swift-ci smoke test |
@swift-ci smoke test |
1 similar comment
@swift-ci smoke test |
381ce9b
to
217beaf
Compare
@swift-ci smoke test |
1 similar comment
@swift-ci smoke test |
@swift-ci smoke test |
@swift-ci smoke test |
@swift-ci smoke test |
@swift-ci smoke test Windows platform |
@swift-ci smoke test Windows platform |
1 similar comment
@swift-ci smoke test Windows platform |
@swift-ci smoke test Windows |
@swift-ci smoke test Windows platform |
@swift-ci smoke test Windows |
Use SipHash-2-4 to replace llvm::MD5 as the hashing implementation backing Fingerprints and the interface hash.
@swift-ci smoke test |
⛵ |
No description provided.