Concurrency override actor isolation fixes #35270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Infer actor isolation from the overridden declaration unless some other isolation attribute was explicitly specified directly on that declaration. This allows type- and extension-level annotations with a global actor to not break overrides.
…er`. `@asyncHandler` methods can override with a completely different actor isolation because they will hop to the appropriate actor themselves. Therefore, allow differing actor isolation when an `@asyncHandler` method overrides another method, and don't propagate the actor isolation from the overridden method to the overriding `@asyncHandler` method.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test macOS |
|
@swift-ci please clean smoke test Linux |
|
@swift-ci please clean smoke test Windows |
|
@swift-ci please clean smoke test macOS |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test macOS |
|
@swift-ci please smoke test Linux |
1 similar comment
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few issues with actor-isolation checking for overrides:
@asyncHandleroverriding declarations to arbitrarily change the actor, because they'll be running the code somewhere else anyway