Skip to content

Correct a Most Vexing Parse in -asserts Builds #35273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2021
Merged

Correct a Most Vexing Parse in -asserts Builds #35273

merged 1 commit into from
Jan 6, 2021

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jan 6, 2021

This thing looks like a function prototype otherwise.

@CodaFi
Correct a Most Vexing Parse in -asserts Builds
ffdd55a 
This thing looks like a function prototype otherwise.
@CodaFi CodaFi requested a review from gottesmm January 6, 2021 03:53
@CodaFi
Copy link
Contributor Author

CodaFi commented Jan 6, 2021

@swift-ci smoke test

davidungar
davidungar approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@davidungar davidungar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into the same thing; thanks for putting up this PR.

@CodaFi
Copy link
Contributor Author

CodaFi commented Jan 6, 2021

@swift-ci smoke test

@CodaFi
Copy link
Contributor Author

CodaFi commented Jan 6, 2021

⛵

@CodaFi CodaFi merged commit 3f91269 into swiftlang:main Jan 6, 2021
@CodaFi CodaFi deleted the parser-koans branch January 6, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidungar davidungar davidungar approved these changes

@DougGregor DougGregor DougGregor approved these changes

@gottesmm gottesmm Awaiting requested review from gottesmm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodaFi @davidungar @DougGregor