[Diagnostics] Special case requirement failures related to return statement/expression
#35281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rement Records protocol requirement associated with a particular type in the constraint system, also useful to track parent conformance for conditional requirements.
… conformances and conditional requirements
…tatement/expression Make sure that "affected" declaration is recognized as the one to which result type is attached to if the requirement failure is originated in contextual type of `return` statement/expression. Resolves: SR-13992 Resolves: rdar://72819046 Resolves: rdar://57789606
|
@swift-ci please smoke test |
hborla
approved these changes
Jan 6, 2021
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new locator path element to track conformance requirements
to avoid loosing track of source of the conditional requirements introduced
into the constraint system. Especially important for protocol composition types
since all of the conformance requirements are anchored at the same locator base.
Make sure that "affected" declaration is recognized as the one
to which result type is attached to if the requirement failure
is originated in contextual type of
returnstatement/expression.Resolves: SR-13992
Resolves: rdar://72819046
Resolves: rdar://57789606