ClangImporter: synchronize clang and Swift #35290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @zoecarver @hlopko @pschuh |
|
@swift-ci please test Windows platform |
|
@swift-ci please test |
|
Build failed |
zoecarver
reviewed
Jan 7, 2021
test/Interop/Cxx/templates/class-template-non-type-parameter.swift
Outdated
Show resolved
Hide resolved
zoecarver
approved these changes
Jan 7, 2021
|
Build failed |
|
@swift-ci please test Windows platform |
This synchronizes the C/C++ standard that Swift uses for the clang importer with the defaults of the clang compiler. The default for the C standard remains the same at `gnu11`. However, if clang was built with a different default C standard, that will be preferred. The default for the C++ standard is moved to C++14. Although this is a reduced version, it matches what the current clang compiler defaults to. Additionally, if the user built clang with a different C++ standard, that standard would be preferred. Although the C++ support is a bit more conservative, the idea is that we can be certain that the clang version fully supports this standard as it it the default version for clang. The test change made here replaces the use of `auto` type parameters to templates which is a C++17 feature. Reduce the example to a C++14 equivalent. The clang version seems to behave differently in preventing the synthesis of the constexpr value. This persists into the newer clang releases as well. This is reasonable as the value does not need to be exported necessarily and users will be able to materialize the value. We use the optimizer to ensure that the value is inlined. This also repairs the C++ interop tests on Windows with a newer C++ runtime from Microsoft.
|
@swift-ci please test |
|
SR-14023 tracks the issue identified here with the materialization of the |
|
Build failed |
|
@swift-ci please test macOS platform |
|
Build failed |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This synchronizes the C/C++ standard that Swift uses for the clang
importer with the defaults of the clang compiler.
The default for the C standard remains the same at
gnu11. However, ifclang was built with a different default C standard, that will be
preferred.
The default for the C++ standard is moved to C++14. Although this is a
reduced version, it matches what the current clang compiler defaults to.
Additionally, if the user built clang with a different C++ standard,
that standard would be preferred.
Although the C++ support is a bit more conservative, the idea is that we
can be certain that the clang version fully supports this standard as it
it the default version for clang.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.