[5.4] Fix _StringObject.init(object:...) #35313
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
Add a missing fix_lifetime. This miscompiles with OSSA because `object` is destroyed before `bridgeObject` is retained. Reinterpreting a reference to a trivial type always requires a fix_lifetime. Fixes rdar://72936583 ([CanonicalOSSA] _StringObject.init(object:...) requires a _fixLifetime call)
atrick
force-pushed
the
5.4-fix-stringinit
branch
from
fce42ee to
a62ec5a
Compare
|
@swift-ci test |
|
-- CCC --- Scope: This was exposed by new OSSA-based optimization within the stdlib; however, the method is inlinable, so the issue could potentially be exposed by unforeseen optimization in the application code. Radar/SR Issue: rdar://72936583 ([CanonicalOSSA] _StringObject.init(object:...) requires a _fixLifetime call) Origin: Primordial Risk: There is a potential risk of minor performance regressions. Improving those will require designing an alternative to _fixLifetime. Testing: Regular testing and benchmarking. Reviewer: @milseman |
|
Original: #35243 |
airspeedswift
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a missing fix_lifetime. This miscompiles with OSSA because
objectis destroyed beforebridgeObjectis retained.Reinterpreting a reference to a trivial type always requires a
fix_lifetime.
Pushing this to 5.4 because it is in inlinable method, so hypothetically the same issue could be exposed by unforeseen optimization in the app code.
Fixes rdar://72936583 ([CanonicalOSSA] _StringObject.init(object:...) requires a _fixLifetime call)