[TypeChecker] NFC: Unify logic in checkDeclarationAvailaibility and…
#35343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `ConstraintSystem::isDeclUnavailable`
xedin
commented
Jan 11, 2021
| })) { | ||
| auto &Context = Where.getDeclContext()->getASTContext(); | ||
| AvailabilityContext safeRangeUnderApprox{ | ||
| AvailabilityInference::availableRange(D, Context)}; |
There was a problem hiding this comment.
@slavapestov Is AvailabilityInference::availableRange(D, Context) an expensive operation? I could try and make sure that it's done only once is so.
There was a problem hiding this comment.
No, it should be pretty cheap. I'll re-run my benchmark with your change.
There was a problem hiding this comment.
Let me know how it goes then and I'll merge these changes if everything is fine.
There was a problem hiding this comment.
You can go ahead and merge it first
|
@swift-ci please smoke test |
slavapestov
approved these changes
Jan 11, 2021
| })) { | ||
| auto &Context = Where.getDeclContext()->getASTContext(); | ||
| AvailabilityContext safeRangeUnderApprox{ | ||
| AvailabilityInference::availableRange(D, Context)}; |
There was a problem hiding this comment.
No, it should be pretty cheap. I'll re-run my benchmark with your change.
|
@swift-ci please smoke test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
ConstraintSystem::isDeclUnavailable